I'm not Scott, but here's my take:
Okay, being a Noob, I have a couple of questions. The pics of your tank look pretty self-explanatory. My questions are:
1) What material do you make the tank out of and where do you get it?
Tin-plated steel. If you buy sheets it'll probably just be called "tin", although "tinplate" and "tin plated steel" will appear too. K&S sells it, or you can start using Powermaster fuel and use old fuel cans. If you have other flyers in your area you may be able to beg some. Some grocery-store items still come in tinplate cans, mostly stuff that has pineapples in it. Grocery-store tinplate cans work, but has ribs, which leads to ribbing from your flying buddies.
2) What type of solder do you use? I assume you use solid core with paste flux rather than flux core?
Nearly anything will work. Some people prefer rosin-core ("electrical") solder because it doesn't leave corrosive flux behind. Some people use paste or liquid flux. Pick your poison -- if you use tinplate that's in good shape it'll solder like a dream with just about anything.
3) What kind of soldering iron/gun do you use?
Just about anything will do. I'm a freelance circuit designer, metalworking hobbyist, and modeler. In addition, my wife used to do stained glass. So we have a LOT of soldering irons around. Just about every one I've tried works. My preference is for one with a massive tip, because the ones with a light-weight tip tend to cool down as soon as they touch the tank, and take some time to heat up again. But people have reported success with just about everything.
4) Any special tips on closing out the tank after the interior is all soldered up?
Start by making sure everything fits really well before applying a drop of solder, and buttoning up the tank will just happen. Be sure to double-check that all the tubes are in the right place and tacked down an both ends before you button it up though -- I never get as good of results when I have to open a tank and re-close it than I do the first time around.
Be sure to pressure test when you're done. I plug off all the tubes but one, hold the tank underwater, and fill it with a fueling syringe. Usually everything is fine the first time out, but sometimes there's leaks, which you then identify by the bubbles and fix.
5) Any good videos/web pages on making tanks?
Yes, but I can't point you to any. Google is your friend. There are magazine articles and threads right here on Stunthanger, too.
6) I have commercial tanks that some say are prone to leaking. Use the same iron/gun and solder you use on your tanks to go back over those commercial joints?
Yes. Use the same pressure test, then fix with a soldering gun/iron/whatever.
Thanks,
Mark
You are welcome, for whatever my babbling is worth.